Use click instead of argparse on PydanticAI CLI #3080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@DouweM Unrelated linting errors to this PR still seem to be showing up. Thought it was an issue with my rebase in my closed PR |
Closed
Collaborator
|
@assadyousuf Looking it |
Contributor
Author
|
Everything is ready on this PR now |
Collaborator
Kludex
reviewed
Oct 10, 2025
…his so pyright stops complaining
assadyousuf
commented
Nov 11, 2025
| "examples/pydantic_ai_examples/weather_agent_gradio.py", | ||
| "pydantic_ai_slim/pydantic_ai/ext/aci.py", # aci-sdk is too niche to be added as an (optional) dependency | ||
| "pydantic_ai_slim/pydantic_ai/ext/aci.py", # aci-sdk is too niche to be added as an (optional) dependency | ||
| "examples/pydantic_ai_examples/slack_lead_qualifier/modal.py", # modal does not fully define its types, so we need this to stop pyright from complaining. |
Contributor
Author
There was a problem hiding this comment.
Ran make sync due to adding click as a dependency. The upgrade to modal lib reflected here as a result of the package upgrades introduces some types that are not fully defined. Added this so the linter stops complaining and CI passes
Contributor
Author
|
@Kludex Can i get one more review on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1702